Add warning from user input #41
Open
+24
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hello @franmomu, thank you for the PR and also for the test, very much appreciated! I want to come back to this and give this another review after more thought, the suggestion language has some unique context. Zxcvbn-PHP doesn't know why a call is passing user data so the suggestion shouldn't make too many assumptions. |
bjeavons
reviewed
May 14, 2020
bjeavons
reviewed
May 14, 2020
franmomu
force-pushed
the
add_warning_user_input
branch
from
0a405a0 to
f1290df
Compare
franmomu
force-pushed
the
add_warning_user_input
branch
from
f1290df to
8391f06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user input is the main cause, the warning message was empty.
I added one, but since I'm not a native speaker (as you can notice 😬), any suggestion for the message is more than welcome.
I also added some phpstan doc: https://phpstan.org/r/68533b15-9d58-4205-9a0f-5664c8aca3fe